reimplement OpenSHC::AI::AICState by gynt · Pull Request #165 · sourcehold/OpenSHC

gynt · 2026-07-19T16:13:22Z

Currently did only a first pass using Claude. Not all methods yet, I ran out of tokens. I used TRD's skill documents, ghidra-mcp, and the tools/mcp/decomphelper.py script succesfully.

I guess it is better if I use
git restore --source otherbranch path/to/myfile.txt
to pick the 100% files and push them separately, deleting those files from this PR

gynt · 2026-07-25T20:35:12Z

See 2d8606c

gynt · 2026-09-22T15:37:09Z

Currently remaining:

  OpenSHC::AI::AICState::setAICParameters_15 (0x4ca4d0) is 74.92% similar to the original
  OpenSHC::AI::AICState::generateSiegeCreationInformation (0x4cc420) is 37.96% similar to the original
  OpenSHC::AI::AICState::smallestTribeOfUnitType (0x4cc990) is 40.93% similar to the original
  OpenSHC::AI::AICState::getSmallestPatrolTribe (0x4ccaf0) is 68.12% similar to the original
  OpenSHC::AI::AICState::addUnitToSmallestBehaviourTypeTribe (0x4ccd20) is 63.91% similar to the original
  OpenSHC::AI::AICState::recruitHarrassingSiegeEngines (0x4cd2a0) is 59.57% similar to the original
  OpenSHC::AI::AICState::instructTribe166ToMove (0x4cd7b0) is 76.14% similar to the original
  OpenSHC::AI::AICState::giveMoveCommandToSortieUnits (0x4cd8f0) is 74.19% similar to the original
  OpenSHC::AI::AICState::chooseRandomBuildingIDFromPlayersArrayOfBuildings (0x4cdb20) is 23.30% similar to the original
  OpenSHC::AI::AICState::getTargetableBuildingForPlayerID (0x4cdbc0) is 65.04% similar to the original
  OpenSHC::AI::AICState::aiShouldAttackOrWaitForTeamCoordination (0x4cdcf0) is 41.75% similar to the original
  OpenSHC::AI::AICState::setCurrentAttackStrength (0x4cde60) is 76.09% similar to the original
  OpenSHC::AI::AICState::setCurrentAttackRaidParameter (0x4cdf10) is 72.00% similar to the original
  OpenSHC::AI::AICState::computeEnemyKeepApproachTile (0x4ce200) is 55.26% similar to the original
  OpenSHC::AI::AICState::aiCommandTribe13DefensiveWave (0x4cf270) is 62.22% similar to the original
  OpenSHC::AI::AICState::aiCommandTribe12AggressiveApproach (0x4cf2e0) is 46.81% similar to the original
  OpenSHC::AI::AICState::setTribe0xCtoAggressiveAndAttack (0x4cf400) is 62.22% similar to the original
  OpenSHC::AI::AICState::aiCommandTribe11StandGroundToGate (0x4cf470) is 56.00% similar to the original
  OpenSHC::AI::AICState::sendAITribe_0xf_toAttackPatrol (0x4cf4f0) is 57.14% similar to the original
  OpenSHC::AI::AICState::setTribe0x11ToAggressiveAndAttackIfConditionMet (0x4cf560) is 37.74% similar to the original
  OpenSHC::AI::AICState::setTribe0xbToAggressiveAndAttack (0x4cf6e0) is 62.22% similar to the original
  OpenSHC::AI::AICState::sendTribeToAttack (0x4cf750) is 62.22% similar to the original
  OpenSHC::AI::AICState::aiCommandSiegeEngineTribes (0x4cfcd0) is 55.97% similar to the original
  OpenSHC::AI::AICState::playNervous2BikFromPlayer (0x4d0b10) is 68.00% similar to the original
  OpenSHC::AI::AICState::renderDebugDataAiInfo (0x4d1320) is 69.55% similar to the original
  OpenSHC::AI::AICState::setInitialAIC (0x4d18b0) is 67.92% similar to the original
  OpenSHC::AI::AICState::decideOnTribeAttackLocation (0x4d1a00) is 58.00% similar to the original
  OpenSHC::AI::AICState::sellExcessGoods (0x4d1d60) is 52.55% similar to the original
  OpenSHC::AI::AICState::aiCreateSiegeUnits (0x4d2000) is 29.44% similar to the original
  OpenSHC::AI::AICState::assignUnitToATribe (0x4d2660) is 59.57% similar to the original
  OpenSHC::AI::AICState::addUnitToSmallestPatrolTribe (0x4d2730) is 79.17% similar to the original
  OpenSHC::AI::AICState::aiGiveOuterPatrolCommand (0x4d28b0) is 73.04% similar to the original
  OpenSHC::AI::AICState::aiGiveRaidInstructions (0x4d2a70) is 30.02% similar to the original
  OpenSHC::AI::AICState::computeAttackPossibilities (0x4d2ec0) is 74.14% similar to the original
  OpenSHC::AI::AICState::computeNervousness (0x4d3780) is 74.02% similar to the original
  OpenSHC::AI::AICState::aiRecruitUnits (0x4d3ae0) is 35.82% similar to the original
  OpenSHC::AI::AICState::sendWallPatrolUnitTribesToAIVLocations (0x4d4340) is 57.89% similar to the original
  OpenSHC::AI::AICState::selectAttackTarget (0x4d4680) is 64.77% similar to the original
  OpenSHC::AI::AICState::updateAIPlayerState (0x4d49e0) is 54.70% similar to the original

Full progress:

  OpenSHC::AI::AICState::wipeAICMemory (0x4c6d30) is 93.75% similar to the original
  OpenSHC::AI::AICState::setAICParameters_01 (0x4c6d60) is 92.16% similar to the original
  OpenSHC::AI::AICState::setAICParameters_02 (0x4c7120) is 83.72% similar to the original
  OpenSHC::AI::AICState::setAICParameters_03 (0x4c7520) is 94.08% similar to the original
  OpenSHC::AI::AICState::setAICParameters_04 (0x4c7910) is 81.94% similar to the original
  OpenSHC::AI::AICState::setAICParameters_05 (0x4c7d20) is 81.53% similar to the original
  OpenSHC::AI::AICState::setAICParameters_06 (0x4c8110) is 84.28% similar to the original
  OpenSHC::AI::AICState::setAICParameters_07 (0x4c8530) is 94.70% similar to the original
  OpenSHC::AI::AICState::setAICParameters_08 (0x4c8920) is 87.50% similar to the original
  OpenSHC::AI::AICState::setAICParameters_09 (0x4c8d20) is 90.38% similar to the original
  OpenSHC::AI::AICState::setAICParameters_10 (0x4c9120) is 80.00% similar to the original
  OpenSHC::AI::AICState::setAICParameters_11 (0x4c94f0) is 89.54% similar to the original
  OpenSHC::AI::AICState::setAICParameters_12 (0x4c9900) is 84.21% similar to the original
  OpenSHC::AI::AICState::setAICParameters_13 (0x4c9cf0) is 83.33% similar to the original
  OpenSHC::AI::AICState::setAICParameters_14 (0x4ca0c0) is 82.35% similar to the original
  OpenSHC::AI::AICState::setAICParameters_15 (0x4ca4d0) is 74.92% similar to the original
  OpenSHC::AI::AICState::setAICParameters_16 (0x4ca8a0) is 84.75% similar to the original
  OpenSHC::AI::AICState::clearPlayerDataInformationChunk (0x4cac70) is 95.24% similar to the original
  OpenSHC::AI::AICState::setTargetForTribeBasedOnTargetChoiceLogic (0x4cacb0) is 97.16% similar to the original
  OpenSHC::AI::AICState::aiUpdateTaxesAndRations (0x4caea0) is 100.00% similar to the original
  OpenSHC::AI::AICState::setFoodBuyPlan (0x4cb060) is 100.00% similar to the original
  OpenSHC::AI::AICState::getAIBuildInterval (0x4cb120) is 100.00% similar to the original
  OpenSHC::AI::AICState::getResourceRebuildDelay (0x4cb150) is 100.00% similar to the original
  OpenSHC::AI::AICState::aiFarmChoice (0x4cb180) is 100.00% similar to the original
  OpenSHC::AI::AICState::setNextFarmTypeToBuild (0x4cb1b0) is 100.00% similar to the original
  OpenSHC::AI::AICState::aiShouldBuildFarm (0x4cb220) is 97.83% similar to the original
  OpenSHC::AI::AICState::aiShouldBuildWoodcutter (0x4cb290) is 98.11% similar to the original
  OpenSHC::AI::AICState::aiShouldBuildQuarry (0x4cb330) is 97.50% similar to the original
  OpenSHC::AI::AICState::aiRequiresExtraOxtethers (0x4cb3a0) is 85.29% similar to the original
  OpenSHC::AI::AICState::aiShouldBuildIronMine (0x4cb4d0) is 97.50% similar to the original
  OpenSHC::AI::AICState::aiShouldBuildPitchrig (0x4cb540) is 97.50% similar to the original
  OpenSHC::AI::AICState::shouldNotBeBuildingHovel (0x4cb5b0) is 91.30% similar to the original
  OpenSHC::AI::AICState::shouldWaitWithBuildingNegativeFearFactor (0x4cb610) is 100.00% similar to the original
  OpenSHC::AI::AICState::shouldWaitWithBuildingAPositiveFearFactor (0x4cb700) is 100.00% similar to the original
  OpenSHC::AI::AICState::destroyHouse (0x4cb810) is 92.31% similar to the original
  OpenSHC::AI::AICState::shouldDestroyWoodCutterUnk (0x4cb890) is 92.16% similar to the original
  OpenSHC::AI::AICState::destroyBuildingIfNoWorker (0x4cb940) is 88.89% similar to the original
  OpenSHC::AI::AICState::shouldNotBuildMarketArmoryGranaryBarracksMercenarypost (0x4cb9f0) is 100.00%* similar to the original
  OpenSHC::AI::AICState::planToBuyWhenLowOnResourceAndSnoozeBuildings (0x4cba50) is 85.08% similar to the original
  OpenSHC::AI::AICState::setupWorkshopProductionType (0x4cbe30) is 96.39% similar to the original
  OpenSHC::AI::AICState::sellGoods (0x4cbfa0) is 90.91% similar to the original
  OpenSHC::AI::AICState::buyGoods (0x4cc000) is 92.86% similar to the original
  OpenSHC::AI::AICState::randomlySelectAttackUnitTypeToRecruit (0x4cc070) is 99.28% similar to the original
  OpenSHC::AI::AICState::getUnitTypeForUnitBehaviourType (0x4cc250) is 94.25% similar to the original
  OpenSHC::AI::AICState::generateSiegeCreationInformation (0x4cc420) is 37.96% similar to the original
  OpenSHC::AI::AICState::aiRecruitEngineers (0x4cc520) is 93.75% similar to the original
  OpenSHC::AI::AICState::assignRequiredIdleEngineersToNewTribe (0x4cc5a0) is 85.71% similar to the original
  OpenSHC::AI::AICState::addEngineersToSelection (0x4cc680) is 83.33% similar to the original
  OpenSHC::AI::AICState::addUnitsToTribe166 (0x4cc720) is 95.24% similar to the original
  OpenSHC::AI::AICState::syncBehaviourType7UnitTribes (0x4cc7b0) is 95.24% similar to the original
  OpenSHC::AI::AICState::aiAddUnitToMoatDiggerTribe (0x4cc840) is 94.29% similar to the original
  OpenSHC::AI::AICState::unitIDIsRangedOrArmored (0x4cc8d0) is 100.00% similar to the original
  OpenSHC::AI::AICState::createTribeForUnitType (0x4cc910) is 97.06% similar to the original
  OpenSHC::AI::AICState::smallestTribeOfUnitType (0x4cc990) is 40.93% similar to the original
  OpenSHC::AI::AICState::getSmallestPatrolTribe (0x4ccaf0) is 68.12% similar to the original
  OpenSHC::AI::AICState::getDefensiveTribeForUnit (0x4ccbe0) is 99.01% similar to the original
  OpenSHC::AI::AICState::addUnitToSmallestBehaviourTypeTribe (0x4ccd20) is 63.91% similar to the original
  OpenSHC::AI::AICState::sendUnitsToKeep (0x4cd0c0) is 94.44% similar to the original
  OpenSHC::AI::AICState::sendUnitsToCampfire (0x4cd110) is 94.44% similar to the original
  OpenSHC::AI::AICState::digNearestMoat (0x4cd160) is 91.67% similar to the original
  OpenSHC::AI::AICState::canNavigateUnitsFromTileToTargetTile (0x4cd250) is 94.74% similar to the original
  OpenSHC::AI::AICState::recruitHarrassingSiegeEngines (0x4cd2a0) is 59.57% similar to the original
  OpenSHC::AI::AICState::aiRecruitSortieRangedUnits (0x4cd560) is 95.24% similar to the original
  OpenSHC::AI::AICState::aiRecruitSortieMeleeUnits (0x4cd690) is 94.94% similar to the original
  OpenSHC::AI::AICState::instructTribe166ToMove (0x4cd7b0) is 76.14% similar to the original
  OpenSHC::AI::AICState::giveMoveCommandToSortieUnits (0x4cd8f0) is 74.19% similar to the original
  OpenSHC::AI::AICState::addBuildingToTargetableBuildings (0x4cda50) is 100.00% similar to the original
  OpenSHC::AI::AICState::selectBuildingFromAListOfBuildingTypes (0x4cdab0) is 100.00% similar to the original
  OpenSHC::AI::AICState::chooseRandomBuildingIDFromPlayersArrayOfBuildings (0x4cdb20) is 23.30% similar to the original
  OpenSHC::AI::AICState::getTargetableBuildingForPlayerID (0x4cdbc0) is 65.04% similar to the original
  OpenSHC::AI::AICState::selectRandomBuildingIDFromListOfBuildingTypes (0x4cdca0) is 95.65% similar to the original
  OpenSHC::AI::AICState::aiShouldAttackOrWaitForTeamCoordination (0x4cdcf0) is 41.75% similar to the original
  OpenSHC::AI::AICState::setCurrentAttackStrength (0x4cde60) is 76.09% similar to the original
  OpenSHC::AI::AICState::setCurrentAttackRaidParameter (0x4cdf10) is 72.00% similar to the original
  OpenSHC::AI::AICState::setAttackPrimeInfo (0x4cdfd0) is 100.00% similar to the original
  OpenSHC::AI::AICState::recomputeAIPathCostToAttackedKeep (0x4ce040) is 93.55% similar to the original
  OpenSHC::AI::AICState::recomputeAttackAIZone (0x4ce110) is 92.86% similar to the original
  OpenSHC::AI::AICState::recomputeAIZonerLayer (0x4ce1a0) is 85.71% similar to the original
  OpenSHC::AI::AICState::computeEnemyKeepApproachTile (0x4ce200) is 55.26% similar to the original
  OpenSHC::AI::AICState::setNextMoveLocationForUnits (0x4ce3b0) is 91.18% similar to the original
  OpenSHC::AI::AICState::removeOrganismsAndSetMoveDestinationPairs (0x4ce430) is 91.49% similar to the original
  OpenSHC::AI::AICState::aiRetreatUnits (0x4ce4d0) is 93.83% similar to the original
  OpenSHC::AI::AICState::sendUnitsToPlayerIDsKeepIfPossible (0x4ce5f0) is 93.50% similar to the original
  OpenSHC::AI::AICState::clearRallyFlagOnAllAIAttackTribes (0x4ce790) is 98.00% similar to the original
  OpenSHC::AI::AICState::moveAttackTribesToLocations (0x4ce830) is 98.67% similar to the original
  OpenSHC::AI::AICState::findAttackTribePositionAndPathToDefenses (0x4ce930) is 86.96% similar to the original
  OpenSHC::AI::AICState::makeUnitsGoDefensiveAndBackToSomeLocation (0x4cea50) is 92.75% similar to the original
  OpenSHC::AI::AICState::giveMoveCommandToAttackTribes (0x4ceb50) is 98.80% similar to the original
  OpenSHC::AI::AICState::aiChoiceAttForceRallyPercentage (0x4cec80) is 100.00% similar to the original
  OpenSHC::AI::AICState::percentageNonMovingTribesGTEAICSpecified (0x4ced90) is 100.00% similar to the original
  OpenSHC::AI::AICState::processAttForceRallyPercentage (0x4ceea0) is 100.00% similar to the original
  OpenSHC::AI::AICState::useAITribe_0x12_toPlaceSiegeTentsAndAssignEngineers (0x4cefd0) is 97.50% similar to the original
  OpenSHC::AI::AICState::useAITribe_0xe_toPlaceTunnels (0x4cf180) is 93.44% similar to the original
  OpenSHC::AI::AICState::aiCommandTribe13DefensiveWave (0x4cf270) is 62.22% similar to the original
  OpenSHC::AI::AICState::aiCommandTribe12AggressiveApproach (0x4cf2e0) is 46.81% similar to the original
  OpenSHC::AI::AICState::setTribe0xCtoAggressiveAndAttack (0x4cf400) is 62.22% similar to the original
  OpenSHC::AI::AICState::aiCommandTribe11StandGroundToGate (0x4cf470) is 56.00% similar to the original
  OpenSHC::AI::AICState::sendAITribe_0xf_toAttackPatrol (0x4cf4f0) is 57.14% similar to the original
  OpenSHC::AI::AICState::setTribe0x11ToAggressiveAndAttackIfConditionMet (0x4cf560) is 37.74% similar to the original
  OpenSHC::AI::AICState::setEightTribe0xc0TribesToAggressiveAndAttack (0x4cf5e0) is 97.22% similar to the original
  OpenSHC::AI::AICState::aiCommandWallAssaultTribes (0x4cf660) is 97.22% similar to the original
  OpenSHC::AI::AICState::setTribe0xbToAggressiveAndAttack (0x4cf6e0) is 62.22% similar to the original
  OpenSHC::AI::AICState::sendTribeToAttack (0x4cf750) is 62.22% similar to the original
  OpenSHC::AI::AICState::commandFourTribesToMove (0x4cf7c0) is 98.15% similar to the original
  OpenSHC::AI::AICState::clearOutdatedAITribes (0x4cf870) is 100.00% similar to the original
  OpenSHC::AI::AICState::giveSomeRaidCommand (0x4cf920) is 96.88% similar to the original
  OpenSHC::AI::AICState::addRallyPointForTribe (0x4cfa10) is 96.88% similar to the original
  OpenSHC::AI::AICState::disbandAIPlayerSiegeUnits (0x4cfb20) is 97.83% similar to the original
  OpenSHC::AI::AICState::countSiegeEngineUnits (0x4cfbc0) is 100.00%* similar to the original
  OpenSHC::AI::AICState::aiCommandSiegeEngineTribes (0x4cfcd0) is 55.97% similar to the original
  OpenSHC::AI::AICState::yieldCowThrow (0x4cff60) is 100.00% similar to the original
  OpenSHC::AI::AICState::hasNoTroopsOrAllAreDiggers (0x4cffd0) is 100.00% similar to the original
  OpenSHC::AI::AICState::hasNotEnoughSupplies (0x4d00a0) is 100.00% similar to the original
  OpenSHC::AI::AICState::setAttackCoordinationLevel (0x4d0110) is 97.56% similar to the original
  OpenSHC::AI::AICState::teamIsWeakRelativeToEnemy (0x4d0190) is 87.32% similar to the original
  OpenSHC::AI::AICState::destroyAnyBuildingInCategory (0x4d0280) is 98.19% similar to the original
  OpenSHC::AI::AICState::isResourceLargerOrEqualThanMinimumGoodsRequiredAfterTrade (0x4d0520) is 100.00% similar to the original
  OpenSHC::AI::AICState::aiOfTypeInCurrentGame (0x4d0580) is 100.00%* similar to the original
  OpenSHC::AI::AICState::shareGoldAmongTeamMembers (0x4d05d0) is 96.35% similar to the original
  OpenSHC::AI::AICState::playTauntToAttackedPlayerBikFromPlayer (0x4d07c0) is 94.29% similar to the original
  OpenSHC::AI::AICState::playAnger1BikFromPlayer (0x4d0830) is 94.29% similar to the original
  OpenSHC::AI::AICState::playPlayerKilledBiksFromKilledAndKillerPlayer (0x4d08b0) is 91.74% similar to the original
  OpenSHC::AI::AICState::playGoodsRequestBikFromPlayerToPlayer (0x4d0a20) is 91.67% similar to the original
  OpenSHC::AI::AICState::playThanksBikFromPlayerToPlayer (0x4d0a80) is 95.24% similar to the original
  OpenSHC::AI::AICState::playNervous2BikFromPlayer (0x4d0b10) is 68.00% similar to the original
  OpenSHC::AI::AICState::playGoodsNotSentBikFromPlayer (0x4d0b70) is 88.89% similar to the original
  OpenSHC::AI::AICState::playGoodsSentBikFromPlayerToPlayer (0x4d0bb0) is 90.48% similar to the original
  OpenSHC::AI::AICState::playAnger2BikFromPlayerToPlayer (0x4d0c00) is 92.86% similar to the original
  OpenSHC::AI::AICState::playVictory2BikFromPlayerToPlayer (0x4d0c70) is 91.89% similar to the original
  OpenSHC::AI::AICState::playNervous1BikFromPlayer (0x4d0cf0) is 90.48% similar to the original
  OpenSHC::AI::AICState::playRequestHelpBikFromPlayer (0x4d0d40) is 92.86% similar to the original
  OpenSHC::AI::AICState::playJokeBikFromAIToHuman (0x4d0f90) is 86.67% similar to the original
  OpenSHC::AI::AICState::playFriendlyVictoryBikFromPlayer (0x4d0fc0) is 88.89% similar to the original
  OpenSHC::AI::AICState::playTeamWinningBikFromPlayer (0x4d1000) is 90.91% similar to the original
  OpenSHC::AI::AICState::playNoHelpBikFromPlayer (0x4d1050) is 88.89% similar to the original
  OpenSHC::AI::AICState::setTriggerForAITauntResponse (0x4d1090) is 90.00% similar to the original
  OpenSHC::AI::AICState::someChatMessageSelection (0x4d10b0) is 96.69% similar to the original
  OpenSHC::AI::AICState::getCurrentDesiredAttackRaidUnitCount (0x4d12a0) is 100.00% similar to the original
  OpenSHC::AI::AICState::renderDebugDataAiInfo (0x4d1320) is 69.55% similar to the original
  OpenSHC::AI::AICState::setInitialAIC (0x4d18b0) is 67.92% similar to the original
  OpenSHC::AI::AICState::aiRegisterTribeAndAssignTarget (0x4d1950) is 98.00% similar to the original
  OpenSHC::AI::AICState::decideOnTribeAttackLocation (0x4d1a00) is 58.00% similar to the original
  OpenSHC::AI::AICState::sellExcessGoods (0x4d1d60) is 52.55% similar to the original
  OpenSHC::AI::AICState::requestGoods (0x4d1f00) is 97.33% similar to the original
  OpenSHC::AI::AICState::aiCreateSiegeUnits (0x4d2000) is 29.44% similar to the original
  OpenSHC::AI::AICState::aiRecruitEngineerForOilDuty (0x4d2500) is 94.57% similar to the original
  OpenSHC::AI::AICState::assignUnitToATribe (0x4d2660) is 59.57% similar to the original
  OpenSHC::AI::AICState::addUnitToSmallestPatrolTribe (0x4d2730) is 79.17% similar to the original
  OpenSHC::AI::AICState::aiAssignUnitToDefensiveTribe (0x4d2790) is 91.30% similar to the original
  OpenSHC::AI::AICState::addUnitToItsTribe (0x4d27e0) is 92.00% similar to the original
  OpenSHC::AI::AICState::ifHasTribe0SendUnitsToKeep (0x4d2830) is 94.74% similar to the original
  OpenSHC::AI::AICState::sendTribeAtOffset1ToCampfire (0x4d2870) is 94.74% similar to the original
  OpenSHC::AI::AICState::aiGiveOuterPatrolCommand (0x4d28b0) is 73.04% similar to the original
  OpenSHC::AI::AICState::aiGiveRaidInstructions (0x4d2a70) is 30.02% similar to the original
  OpenSHC::AI::AICState::sendTribeToAIVLocationSlot (0x4d2e00) is 95.45% similar to the original
  OpenSHC::AI::AICState::computeAttackPossibilities (0x4d2ec0) is 74.14% similar to the original
  OpenSHC::AI::AICState::moveAttackingUnitsToNextRallyPoint (0x4d2f80) is 95.56% similar to the original
  OpenSHC::AI::AICState::sendUnitsToAttackBreachedCastle (0x4d30e0) is 95.45% similar to the original
  OpenSHC::AI::AICState::updateAIStrengthState (0x4d3320) is 87.69% similar to the original
  OpenSHC::AI::AICState::computeNervousness (0x4d3780) is 74.02% similar to the original
  OpenSHC::AI::AICState::determineAIPlayerHelp (0x4d3850) is 82.35% similar to the original
  OpenSHC::AI::AICState::determineAIPlayerAttackRequestResponse (0x4d38c0) is 83.78% similar to the original
  OpenSHC::AI::AICState::Constructor_AICState (0x4d3940) is 85.71% similar to the original
  OpenSHC::AI::AICState::makeOutpostTribesAttack (0x4d3960) is 96.43% similar to the original
  OpenSHC::AI::AICState::buyRequiredGoods (0x4d39b0) is 96.63% similar to the original
  OpenSHC::AI::AICState::aiRecruitUnits (0x4d3ae0) is 35.82% similar to the original
  OpenSHC::AI::AICState::aiAssignMoatDiggers (0x4d3f20) is 97.40% similar to the original
  OpenSHC::AI::AICState::addEngineersToTribe (0x4d4040) is 96.97% similar to the original
  OpenSHC::AI::AICState::aiReassignTunnelersToTribe (0x4d40b0) is 94.87% similar to the original
  OpenSHC::AI::AICState::sendRangedUnitTribesToAIVSlotsOrKeepIfNervous (0x4d4130) is 97.06% similar to the original
  OpenSHC::AI::AICState::sendCertainUnitTribesToAIVSlotsOrKeepIfNervousAndNotEnclosed (0x4d4220) is 96.30% similar to the original
  OpenSHC::AI::AICState::sendWallPatrolUnitTribesToAIVLocations (0x4d4340) is 57.89% similar to the original
  OpenSHC::AI::AICState::sendOilMenForOilPickupOrToAIVLocations (0x4d44e0) is 95.77% similar to the original
  OpenSHC::AI::AICState::abortAttackAndGoIdle (0x4d45e0) is 84.62% similar to the original
  OpenSHC::AI::AICState::recreateEngineersTribe (0x4d4630) is 94.44% similar to the original
  OpenSHC::AI::AICState::selectAttackTarget (0x4d4680) is 64.77% similar to the original
  OpenSHC::AI::AICState::aiBuyAndSellGoods (0x4d48f0) is 86.67% similar to the original
  OpenSHC::AI::AICState::updateTribeLocations (0x4d4940) is 82.22% similar to the original
  OpenSHC::AI::AICState::updateAIPlayerState (0x4d49e0) is 54.70% similar to the original
  OpenSHC::AI::AICState::updateAIBehaviour (0x4d53e0) is 85.21% similar to the original
  OpenSHC::AI::AICState::shouldNotBeBuildingGranary (0x4eca30) is 100.00% similar to the original
  OpenSHC::AI::AICState::shouldNotBeBuildingArmoury (0x4eca60) is 100.00% similar to the original
  OpenSHC::AI::AICState::shouldNotBuildKillingPits (0x4eca90) is 100.00% similar to the original
  OpenSHC::AI::AICState::mapperIsWoodCuttersHutWhileNoWoodAvailable (0x4ecab0) is 100.00% similar to the original

gynt · 2026-09-22T18:03:10Z

@TheRedDaemon I have requested your review. I assume it will take a while because there are so many functions to review. In my PR view on GitHub they do look very neatly organized, so perhaps you can browse through it.

There is one function that has functional differences, this is: generateSiegeCreationInformation
All the other ones should be functionally the same.

Many non-100% are due to frequent MACRO usage, offset calculations that are cached in the original and added in our version or vice versa. The rest is register scheduling/allocation issues.

Also let's squash and merge this PR.

gynt marked this pull request as draft July 19, 2026 16:13

gynt self-assigned this Jul 19, 2026

gynt force-pushed the reimpl/AICState branch from 83934e7 to 560411d Compare July 19, 2026 23:10

gynt force-pushed the reimpl/AICState branch 2 times, most recently from eadf1c4 to b86fb18 Compare July 29, 2026 09:16

gynt force-pushed the reimpl/AICState branch from 2a76afb to c647d52 Compare August 3, 2026 21:26

sourcehold and others added 22 commits August 16, 2026 22:11

reimplement OpenSHC::AI::AICState: first pass

cd47125

pass 2

10a9b3d

processed ghidra changes

11e30f4

more rough unchecked reimplementations

dfbd12a

batch 4 unpolished

3c1a7c4

batch 5 unpolished

c946f8c

clang-formatting

d9d9fd6

ghidra-cpp and claude fixes

ccdcdb7

fit improvements

9e5eb41

better or worse

8b73c02

param change

dd6fa45

improvements

07f71d2

field name updates

c6d5282

improve readability and fit

80d83ca

as best as we can

62ab83f

improve rally percentage

3894bd2

OpenSHC::AI::AICState::aiChoiceAttForceRallyPercentage 100%

6f04e8f

slow improvement

dc57850

slow improvement

e25f2bf

integrate main

bc820af

sellExcessGoods 61.18%

2cf4d82

fix typo

a5fac8e

gynt force-pushed the reimpl/AICState branch from e278f53 to a5fac8e Compare August 16, 2026 20:12

gynt added 20 commits September 22, 2026 17:16

reimplement: SHC_3BB0A8C1_0x004C7910 81.94% Constant store order differs

8697155

reimplement: SHC_3BB0A8C1_0x004C7D20 81.53% Constant store order differs

4879caa

reimplement: SHC_3BB0A8C1_0x004C8110 84.28% Constant store order differs

e374dba

reimplement: SHC_3BB0A8C1_0x004C8530 94.70% Constant store order differs

6da6b1a

reimplement: SHC_3BB0A8C1_0x004C8920 87.50% Constant store order differs

9621b2c

reimplement: SHC_3BB0A8C1_0x004C8D20 90.38% Constant store order differs

c22af97

reimplement: SHC_3BB0A8C1_0x004C9120 80.00% Constant store order differs

620fbe4

reimplement: SHC_3BB0A8C1_0x004C94F0 89.54% Constant store order differs

c14c515

reimplement: SHC_3BB0A8C1_0x004C9900 84.21% Constant store order differs

6c01e8b

reimplement: SHC_3BB0A8C1_0x004C9CF0 83.33% Constant store order differs

983d6d1

reimplement: SHC_3BB0A8C1_0x004CA0C0 82.35% Constant store order differs

023068a

reimplement: SHC_3BB0A8C1_0x004CA4D0 74.92% Constant store order differs

ebfb112

reimplement: SHC_3BB0A8C1_0x004CA8A0 84.75% Constant store order differs

7420f91

reimplement: SHC_3BB0A8C1_0x004CB1B0 100.00% Reimplemented

cfafac7

reimplement: SHC_3BB0A8C1_0x004CC7B0 95.24% Reimplemented

6c31c49

reimplement: SHC_3BB0A8C1_0x004CB700 100.00% Reimplemented

b292e09

reimplement: SHC_3BB0A8C1_0x004CB9F0 93.33% Reimplemented

77bb2d1

reimplement: SHC_3BB0A8C1_0x004CB5B0 91.30% Reimplemented

b06799f

reimplement: SHC_3BB0A8C1_0x004D1090 90.00% Reimplemented

d82ee95

reimplement: SHC_3BB0A8C1_0x004CD7B0 76.14% Register allocation differs

2eb1b84

gynt added 5 commits September 22, 2026 19:26

reimplement: SHC_3BB0A8C1_0x004CDF10 98.15% Reimplemented

8569de1

reimplement: SHC_3BB0A8C1_0x004CDE60 76.09% AIC index folding differs

ac81515

reimplement: SHC_3BB0A8C1_0x004D0B10 68.00% Load scheduling differs

6912297

progres

ff58615

reimplement: SHC_3BB0A8C1_0x004D1D60 57.99% Register allocation differs

554ff49

gynt requested a review from TheRedDaemon September 22, 2026 18:00

gynt marked this pull request as ready for review September 22, 2026 18:03

repair formatting issues

023be2c

Navigation Menu

reimplement OpenSHC::AI::AICState - #165

reimplement OpenSHC::AI::AICState#165
gynt wants to merge 243 commits into
mainfrom
reimpl/AICState

gynt commented Jul 19, 2026 •

edited

Loading

Uh oh!

gynt commented Jul 25, 2026

Uh oh!

gynt commented Sep 22, 2026 •

edited

Loading

Uh oh!

gynt commented Sep 22, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gynt commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gynt commented Jul 25, 2026

Uh oh!

gynt commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gynt commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gynt commented Jul 19, 2026 •

edited

Loading

gynt commented Sep 22, 2026 •

edited

Loading

gynt commented Sep 22, 2026 •

edited

Loading